You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
51 lines
1.7 KiB
51 lines
1.7 KiB
4 years ago
|
https://bugs.gentoo.org/706660
|
||
|
https://git.kernel.org/pub/scm/utils/dtc/dtc.git/patch/?id=0e9225eb0dfec51def612b928d2f1836b092bc7e
|
||
|
|
||
|
From 0e9225eb0dfec51def612b928d2f1836b092bc7e Mon Sep 17 00:00:00 2001
|
||
|
From: Dirk Mueller <dmueller@suse.com>
|
||
|
Date: Tue, 14 Jan 2020 18:53:41 +0100
|
||
|
Subject: Remove redundant YYLOC global declaration
|
||
|
|
||
|
gcc 10 will default to -fno-common, which causes this error at link
|
||
|
time:
|
||
|
|
||
|
(.text+0x0): multiple definition of `yylloc'; dtc-lexer.lex.o (symbol from plugin):(.text+0x0): first defined here
|
||
|
|
||
|
This is because both dtc-lexer as well as dtc-parser define the same
|
||
|
global symbol yyloc. Before with -fcommon those were merged into one
|
||
|
defintion. The proper solution would be to to mark this as "extern",
|
||
|
however that leads to:
|
||
|
|
||
|
dtc-lexer.l:26:16: error: redundant redeclaration of 'yylloc' [-Werror=redundant-decls]
|
||
|
26 | extern YYLTYPE yylloc;
|
||
|
| ^~~~~~
|
||
|
In file included from dtc-lexer.l:24:
|
||
|
dtc-parser.tab.h:127:16: note: previous declaration of 'yylloc' was here
|
||
|
127 | extern YYLTYPE yylloc;
|
||
|
| ^~~~~~
|
||
|
cc1: all warnings being treated as errors
|
||
|
|
||
|
which means the declaration is completely redundant and can just be
|
||
|
dropped.
|
||
|
|
||
|
Signed-off-by: Dirk Mueller <dmueller@suse.com>
|
||
|
Message-Id: <20200114175341.2994-1-dmueller@suse.com>
|
||
|
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
|
||
|
---
|
||
|
dtc-lexer.l | 1 -
|
||
|
1 file changed, 1 deletion(-)
|
||
|
|
||
|
--- a/dtc-lexer.l
|
||
|
+++ b/dtc-lexer.l
|
||
|
@@ -23,7 +23,6 @@ LINECOMMENT "//".*\n
|
||
|
#include "srcpos.h"
|
||
|
#include "dtc-parser.tab.h"
|
||
|
|
||
|
-YYLTYPE yylloc;
|
||
|
extern bool treesource_error;
|
||
|
|
||
|
/* CAUTION: this will stop working if we ever use yyless() or yyunput() */
|
||
|
--
|
||
|
cgit 1.2-0.3.lf.el7
|
||
|
|